Foreach array return last value

Question

I'm learning OOP and I whould create a list of objects in an array, but my code return the last array I have search here, but haven't found a solution or idea how to do this.

Excepct

        "MerchantDefinedFields":[  
        {  
           "Id":2,
           "Value":"[email protected]"
        },
        {  
           "Id":4,
           "Value":"Web"
        },
        {  
           "Id":9,
           "Value":"NAO"
        },
        {  
           "Id":83,
           "Value":"Field"
        },
        {  
           "Id":84,
           "Value":"Only"
        }
     ]

My code

            $MDDs = array(
                array("Id" => 2, "Value" => "[email protected]"), 
                array("Id" => 4, "Value" => "Web"),
                array("Id" => 9, "Value" => "NO"),
                array("Id" => 83, "Value" => "Field"),
                array("Id" => 84, "Value" => "Only")
            );
             
            foreach($MDDs as $MDD){
                $abac = array("Id" => $MDD['Id'], "Value" => $MDD['Value']);
            }

Result

    Array
(
    [Id] => 84
    [Value] => PROPRIO
)

Isn't your output exactly the same as the input? Also just to point out that you are creating a nested array and not an array of objects. — Nigel Ren
– Nigel Ren, Commented Nov 12, 2020 at 18:11

Dave · Accepted Answer · 2020-11-12 18:04:08Z

2

Your foreach() is re-setting $abac every time it goes through the loop. So on the last time it runs, it will set the variable to the last item in your array.

Instead of setting the variable each time, try adding the key->value to an array (or something like that, depending on what you want):

$abac = [];
foreach($MDDs as $MDD){
    $abac[] = array("Id" => $MDD['Id'], "Value" => $MDD['Value']);
}

It's hard to create the exact right answer for you, since it's unclear what you're trying to accomplish, but this should at least point you in the right direction.

answered Nov 12, 2020 at 18:04

Dave

29.2k26 gold badges117 silver badges184 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

santoshe61 · Accepted Answer · 2020-11-12 18:07:11Z

0

For simple answer :- You don't need foreach loop to get the desired result you can simply use built-in php function to convert your array to JSON

$abac = json_encode ( $MDDs);

Now coming to your problem :-

you are re-assigning the $abac variable in loop instead of adding values to it like .

$abac = [];
foreach($MDDs as $MDD){
    $abac[] = array("Id" => $MDD['Id'], "Value" => $MDD['Value']);
}

answered Nov 12, 2020 at 18:07

santoshe61

8139 silver badges18 bronze badges

Comments

Kira steph · Accepted Answer · 2020-11-12 18:21:46Z

0

The best way to do it is to declare the $abac outside of the foreach and then use the array_push method like this:

$abac = array();

foreach($MDDs as $MDD)
{
    array_push($abac, array("Id" => $MDD['Id'], "Value" => $MDD['Value']));
}
print_r($abac);

answered Nov 12, 2020 at 18:21

Kira steph

11 bronze badge

Collectives™ on Stack Overflow

Foreach array return last value

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related