Rails: How can i refactor my controller params code

Question

I need to refactor this private method. Codeclimate is giving me a error msj because the line of the params is too long. How can i refactor it?

def base_plan_params
    params[:base_plan][:debit_date_attributes]&.merge!(
      account_id: current_account.id,
      _destroy: params[:base_plan][:debit_date_attributes][:date_type].blank?,
    )
    params.require(:base_plan).permit(
      :code,
      :cover,
      :name,
      :products,
      :pricing_model,
      :metered,
      debit_date_attributes: %i[id account_id date_type value _destroy],
    )
  end```

Les Nightingill · Accepted Answer · 2021-05-19 03:55:00Z

1

making an assumption here about which CodeClimate "too long" error is being triggered, as you didn't clarify.

You could form the permitted params into an array, like this:

permitted_params = [:code, :cover, :name, :products, :pricing_model, :metered]
params.require(:base_plan).
       permit(*permitted_params, 
              debit_date_attributes: %i[id account_id_data_type value _destroy],)

Personally I wouldn't bother, but if the CodeClimate warning troubles you, then this solution would probably work.

answered May 19, 2021 at 3:55

Les Nightingill

6,1742 gold badges32 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

BeeM Over a year ago

Thank you Les, yes i didn't give too much context, but you have answered my question. The error msj was: line too long, consider refactor.

Collectives™ on Stack Overflow

Rails: How can i refactor my controller params code

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related