NodeJs function not working as expected in Firebase Cloud functions

Question

I do have not any familiarity with node/Js but I have 9 functions that I need to use in Firebase cloud functions, I made a scheduled function on a firebase in nodejs but it's not working as expected.

Just for clarification that the document that I want to update is in this hierarchy in firestore:

users (collection) -> abcUser (document) -> others (collection) -> limiter (document)

Below is one of the functions which is running succefuly on google cloud but the document is not getting update/change:

exports.resetLimiter = functions.pubsub
.schedule("*/5 * * * *")
.onRun( async (context) => {
  const snapshot = await db.collection("users").get();
  for (let i = 0; i < snapshot.docs.length; i++) {
    await snapshot[i].query.get.collection("others").doc("limiter")
        .update({
          weeklyFlow: 0.0,
          monthlyFlow: 0.0,
        });
  }
});

Peace!

Doug Stevenson · Accepted Answer · 2022-08-20 22:06:54Z

1

update() returns a promise, but you're ignoring them. This causes the function to complete without waiting for the updates to complete. You need to await each one before returning.

Also your function seems to be incorrect in the way it uses the Firestore API. There is no property get on DocumentSnapshot objects. I'll try to rewrite it anyway with await.

      for (var i = 0; i < snapshot.docs.length; i++) {
        await db.collection("others").doc("limiter")
            .update({
              weeklyFlow: 0.0,
              monthlyFlow: 0.0,
            });
      });

answered Aug 20, 2022 at 22:06

Doug Stevenson

321k37 gold badges458 silver badges474 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Mohammad Khalid Ibrahimi Over a year ago

Thank you for the prompt reply. The problem is that the "others" collections is inside each document that we get. The "others" collection is an inner collection inside each user document, don't know how to solve that. its still now updating any document.

Mohammad Khalid Ibrahimi Over a year ago

Updated the code portion! please see on the question but its still not working. The hierarchy in firestore is like this: users (collection) -> abcUser (document) -> others (collection) -> limiter (document) which I need to update.

Doug Stevenson Over a year ago

That still doesn't look like valid use of the Firestore API. There is no property query on a document snapshot. I would expect there to be an error message in the logs.

Mohammad Khalid Ibrahimi Over a year ago

Then how to reference the inner collection of the document properly.

Collectives™ on Stack Overflow

NodeJs function not working as expected in Firebase Cloud functions

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related