OpenRewrite NullPointer while adding a maven dependency

Question

I am running a recipe on Mac OS from the command line using rewrite plugin version 4.46.0 The project is a multi module maven.

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -e -Drewrite.activeRecipes=com.xxx.upgrade_18

My rewrite.yml is this

type: specs.openrewrite.org/v1beta/recipe
name: com.xxx.upgrade_18
displayName: XXXX
recipeList:
  - org.openrewrite.maven.AddDependency:
      groupId: com.xxx.yyy
      artifactId: zzzz
      version: 9.9.0

When I run I get a NPE:

    at org.openrewrite.internal.StringUtils.aspectjNameToPattern (StringUtils.java:647)
    at org.openrewrite.java.search.UsesType.<init> (UsesType.java:33)
    at org.openrewrite.maven.AddDependency.getApplicableTest (AddDependency.java:156)
    at org.openrewrite.Recipe.getApplicableTests (Recipe.java:395)

From what I have read the getApplicableTest is called on every file in the project. How can I find the root cause?

Christopher Helck · Accepted Answer · 2023-05-18 21:13:52Z

0

If your recipe does not provide a value for ``onlyIfUsingthen NPE is thrown. What should the value ofonlyIfUsing``` be? I am still trying to figure it out.

answered May 18, 2023 at 21:13

Christopher Helck

1,1402 gold badges8 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Tim · Accepted Answer · 2023-05-19 07:59:12Z

0

onlyIfUsing limits the recipe to only add the recipe when certain import is used. That way you do not get unused dependencies added to just any project, especially with multi module projects.

The documentation for the recipe is here: https://docs.openrewrite.org/recipes/maven/adddependency

That gives a sample value of:

  onlyIfUsing: org.junit.jupiter.api.*

In your case you likely want to use a package from your dependency; possible something like com.xxx.yyy.*

answered May 19, 2023 at 7:59

Tim

20.9k9 gold badges72 silver badges100 bronze badges

3 Comments

Christopher Helck Over a year ago

I got it to work but I am still confused by what "using" means. If I use one of the package names or imports from a java file in my source tree then the dependency is added. Is this the expected behavior? I also noticed that when it adds a dependency it corrects the pom's indentation. Is that expected?

Tim Over a year ago

Yes it's expected that the dependency is only added if you're using one of the classes that matches the onlyIfUsing argument.

Tim Over a year ago

As for pom indentation; what kind of changes are you seeing, and are they problematic? We detect the predominant indentation style, and insert similar indentation. Feel free to raise an issue if you're seeing more than the expected changes

Collectives™ on Stack Overflow

OpenRewrite NullPointer while adding a maven dependency

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related