boolean method issue in one sense

Question

I have the following function in my model

after_save :update_status

def update_status
  if quantity_received >= quantity
    self.received = true
  else
    self.received = false
  end
end

True works great but it doesn't update to false when set to true. Any idea?

tadman · Accepted Answer · 2011-10-21 15:12:44Z

2

When you're defining a callback it is very important you do not inadvertently return false, which is a signal to halt the chain, and that's what you're doing here in one case.

A re-written version that avoids this problem is:

after_save :update_status

def update_status
  self.received = quantity_received >= quantity

  return
end

You can return anything but false, so the last line could be nil or true just the same.

answered Oct 21, 2011 at 15:12

tadman

212k23 gold badges237 silver badges266 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Gaelle Over a year ago

In this case I might not need to store this in the Db. If I do def status quantity_received >= quantity ? true : false end How to render image_tag if true in the view?

tadman Over a year ago

There's no reason to do cond ? true : false because that's equivalent to cond if the condition is a boolean, or !!cond otherwise.

Aditya Sanghi · Accepted Answer · 2011-10-21 15:14:17Z

1

You're assigning to received "after" save. So this assignment doesnt get saved!

Try

before_save :update_received

def update_received
  self.received = quantity_received >= quantity
end

And by "saved" i assume you mean "saved" in the database.

answered Oct 21, 2011 at 15:14

Aditya Sanghi

13.4k2 gold badges49 silver badges50 bronze badges

1 Comment

Gaelle Over a year ago

Thanks for your reply. The 2 solutions combined just work fine

Collectives™ on Stack Overflow

boolean method issue in one sense

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related