3

Intro

I have jscoverage installed and have setup a make command to generate the coverage data to app-cov and runs the tests.

For this project I am using: node.js, mongoose, express, mocha and should.

Relevant files:

Makefile: http://pastie.org/3529374

index.js: http://pastie.org/3529377

test/models/location.test.js: http://pastie.org/3529401

app/run.js: http://pastie.org/3529523

Problem

The output coverage.html file overview is empty. 0% 0 SLOC 0 files in overview.

My assumption is that mocha is not recognizing or loading the coverage from app-cov. I've only written a single unit test for the location model. Is it the way I'm requiring the files in the test?

I'm use to phpunit and it's configuration so I'm having a little trouble putting the test suite together.

Ups to anyone who can recommend a solution or how tidy up my ugle code :)

Improve this question
1
  • the make commands execute without a problem, ignore the dual EXPRESS_COV=1 , those were placed there for debugging. Commented Mar 6, 2012 at 2:35

1 Answer 1

Reset to default
3

Your makefile has many issues.

1- Why do you need the TESTS variable? Your tests are in the test/ subdirectory, so unless you have other .js files there (why would you?), then this is the default for mocha: "By default mocha(1) will use the pattern ./test/*.js, so it’s usually a good place to put your tests."

2- Both your test: and test-cov: entries set the EXPRESS_COV environment variable to 1, meaning that you have no way to run tests without the coverage option (no way with the makefile, that is). This may be fine if you always want to do tests with coverage, but then why have 2 entries? Look at the express library Makefile for a good example. If you follow this example, your test: entry should NOT set EXPRESS_COV.

3- Your gen-cov entry is wrong, it should in fact be called app-cov: based on the name of the subdirectory where you store your instrumented files. By the way, why not choose the standard "lib-cov" (and "lib" for your non-instrumented js files)? Certainly not required, but it is a convention followed by many in the community.

4- Why do you remove your instrumented files before running jscoverage? Not sure if it can cause problems with make, don't think so, but it's useless and should be removed.

5- test-cov should now depend on app-cov (that's probably the heart of the problem, make never detected that the dependency was outdated, because the dependency doesn't exist!). test-cov does and should indeed set the EXPRESS_COV=1 environment variable.

6- In test-cov, your "l" in coverage.html seems to be on a separate line, though it could be the pastebin.

To recap (I've kept app and app-cov, though I suggest lib and lib-cov):

REPORTER = dot
test:
    @NODE_ENV=test ./node_modules/.bin/mocha -b \
    --reporter $(REPORTER)

app-cov:
    jscoverage app app-cov

test-cov: app-cov
    @EXPRESS_COV=1 $(MAKE) test REPORTER=html-cov > docs/report/coverage.html

.PHONY: test

Edit: And I just noticed that in your test code, you require a model explicitly in the /app/ folder. You must use the EXPRESS_COV variable as you did in the index file.

Improve this answer
Sign up to request clarification or add additional context in comments.

5 Comments

I'm refactoring a silex application into a node.js project, I maintained the conventions. mocha would not read my tests recursively, is the reason for the tests var. The redundant EXPRESS_COV was something I was using to debug the issue before I posted. I simply followed the makefile semantics from a tutorial. The wiring doesn't seem to be the issue, nothing you've pointed out is broken by implementation, just semantics. I agree I am misunderstanding a key point in test bootstrapping for the coverage to be analyzed, if you can spot that it would be a lot more helpful.
#3 is not semantics, it is how make works. I'm pointing out numerous issues in your code, I cannot magically know that it was there for debug, I analyze what's posted. My edit tells you why you don't see coverage, since this is your only test, it loads explicitly from app (and not app-cov). And even then, you test if a property exists, depending on the implementation of your model, this may not cover any code. If you call a method on your model, then it will test something.
from the posted makefile, running make gen-cov will have the intended effect. I do not understand your misconception. gen-cov is not a directory, it is a target. In that example I just did not have it set as phony. I have a very anaemic model, by design, and without complex domain operations. This is just a lightweight data store so testing properties will be probably be the girth of my unit tests. After all, instantiating a model and testing for the expected properties makes sense if the model is schema'd by mongoose.
So I think you are saying that my test should load the model through mongoose or another loader instead of using file paths because the model isn't loaded from app-cov.
Looks good, loaded from mongoose and included index.js and I had output from code coverage. Thanks for pointing it out.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.