LINQ - Select correct values from nested collection

Question

Consider the following class hierarchy:

public class Foo
{
 public string Name { get; set; }
 public int Value { get; set; }
}
public class Bar
{
 public string Name { get; set; }
 public IEnumerable<Foo> TheFoo { get; set; }
}

public class Host
{
  public void Go()
  {
    IEnumerable<Bar> allBar = //Build up some large list
    //Get Dictionary<Bar, Foo> with max foo value
  }
}

What I would like to do using Linq2Objects is to get an KeyValuePair where for each Bar in the allBBar collection we select the Foo with the maximum Value property. Can this be done easily in a single LINQ statement?

Jon Skeet · Accepted Answer · 2009-07-08 21:20:24Z

2

Sure, although my preferred solution uses MaxBy from MoreLINQ:

var query = allBar.ToDictionary(x => x, // Key
                                x => x.TheFoo.MaxBy(f => f.Value));

Note that this will go pear-shaped if TheFoo is empty for any Bar instance.

answered Jul 8, 2009 at 21:20

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ray Booysen Over a year ago

And without the MaxBy option?

Jon Skeet Over a year ago

Then you'd basically want to write your own implementation of MaxBy :) You could do something horrible, but it would be a lot neater just to include MaxBy in your code.

Joe Chung · Accepted Answer · 2009-07-10 14:39:26Z

1

Another way using Aggregate instead of OrderBy so that figuring out the max Foo is O(n) instead of O(n log n):

var query = allBar.ToDictionary(
    bar => bar,
    bar => bar.TheFoo.Aggregate(
        null,
        (max, foo) => (max == null || foo.Value > max.Value) ? foo : max));

answered Jul 10, 2009 at 14:39

Joe Chung

12.2k1 gold badge26 silver badges33 bronze badges

Comments

Doctor Jones · Accepted Answer · 2009-07-08 22:31:50Z

0

just to add to Jon's comment about MaxBy going pear shaped if you have no foos, you could do an OrderByDescending and then use FirstOrDefault to get at the Max element. If the collection is empty it'd just return null instead of going "pear shaped".

var foobars = bars.ToDictionary(bar => bar, 
                                bar => bar.TheFoo.OrderByDescending(foo => foo.Value).FirstOrDefault());

I don't think this wouldn't be as efficient as MaxBy, but it'd be more robust in the case of an empty collection.

edited Jul 8, 2009 at 22:31

answered Jul 8, 2009 at 21:33

Doctor Jones

21.8k13 gold badges81 silver badges103 bronze badges

Collectives™ on Stack Overflow

LINQ - Select correct values from nested collection

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related