Sorting algorithm gives wrong results

Question

#include<iostream>
#include<conio.h>

using namespace std;

int main()
{
    int a, b, c[5], d;

    cout << "enter any five number\n";
    for(a=0; a<5; a++)
    {
        cin>>c[a];
    }
    for(a=0; a<5; a++)
    {
        for(b=++a; b<5; b++)
        {
            if(c[b] < c[a])
            {
                d = c[b];
                c[b] = c[a];
                c[a] = d;
            }
        }       
    }

    cout << "\nhere is the entered numbers in order\n"; 
    for(a=0; a<5; a++)
    {
        cout << c[a];
        cout << endl;
    }
    getch();
    return 3;
}

I am desk checking this program and I expect the program to sort numbers in ascending order but I am getting the wrong output help please.

no,no no @MarounMaroun i am sorry, if it's a bad habit this is my last time. — Samuel
– Samuel, Commented Feb 13, 2014 at 10:13
@Ralara: the original format of the title really suggested that this is a task assigned as an excercise — quetzalcoatl
– quetzalcoatl, Commented Feb 13, 2014 at 10:18
It would be helpful if you included a transcript of your desk-check, so that we could help you figure out where exactly your program's behavior differs from what you expected it to do. — ComicSansMS
– ComicSansMS, Commented Feb 13, 2014 at 10:19

Ferenc Deak · Accepted Answer · 2014-02-13 10:15:07Z

1

in the inner loop it should be a + 1 not ++a

answered Feb 13, 2014 at 10:15

Ferenc Deak

35.6k19 gold badges107 silver badges176 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

quetzalcoatl · Accepted Answer · 2014-02-13 10:15:31Z

1

for(a=0;a<5;a++) and for(b=++a;..) causes a to be incremented twice.

Did you mean for(b=a+1;b<5;b++) ?

answered Feb 13, 2014 at 10:15

quetzalcoatl

33.8k9 gold badges75 silver badges117 bronze badges

1 Comment

Samuel Over a year ago

yeah that's what i meant but i did not know that the second loop is the one causing that output, thank you so much @quetzalcoatl

Emu · Accepted Answer · 2014-02-13 10:20:57Z

0

for(a=0; a<5-1; a++){
  for(b=0; b<5-a-1; b++){
    if(c[b] < c[a]){
      d = c[b];
      c[b] = c[a];
      c[a] = d;
    }
  }
}

answered Feb 13, 2014 at 10:20

Emu

5,9253 gold badges35 silver badges52 bronze badges

Comments

Zodoh · Accepted Answer · 2014-02-13 10:33:37Z

0

   for(a=0; a<5; a++)
    {
        for(b=++a; b<5; b++)
        {
            if(c[b] < c[a])
            {
                d = c[b];
                c[b] = c[a];
                c[a] = d;
            }
        }       
    }

this should be

for(a=0; a<4; a++)
{
    for(b=a+1; b<5; b++)
    {
        if(c[b] < c[a])
        {
            d = c[b];
            c[b] = c[a];
            c[a] = d;
        }
    }       
}

edited Feb 13, 2014 at 10:33

answered Feb 13, 2014 at 10:17

Zodoh

1007 bronze badges

1 Comment

Zodoh Over a year ago

a<4 should be better to avoid a useless step.

Collectives™ on Stack Overflow

Sorting algorithm gives wrong results

4 Answers 4

Comments

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related