Issue with Laravel hasMany relation

Question

I’m having an issue with relations in two of my models in a Laravel application. My models are:

class Invoice extends Eloquent {

    protected $table = 'invoices';

    public function line_items()
    {
        return $this->hasMany('LineItem');
    }

}

And:

class LineItem extends Eloquent {

    protected $table = 'line_items';

    public function invoice()
    {
        return $this->belongsTo('Invoice');
    }

}

In my controller, I fetch an Invoice row with the following:

$invoice = Invoice::find($id);

However, if I try and access the line_items property to fetch the LineItem rows relating to my invoice, I get the following error:

Invalid argument supplied for foreach()

Why is this? I’ve set my models up as per Laravel’s documentation: http://laravel.com/docs/eloquent#one-to-many

Where is foreach loop ? Do you have proper keys/fields in tables for making relation ? — The Alpha
– The Alpha, Commented Mar 13, 2014 at 21:08
Tried both in my controller and view: foreach ($invoice->line_items as $line_item) triggers the error. — Martin Bean
– Martin Bean, Commented Mar 13, 2014 at 21:16
Try dd($invoice->line_items) it's not an array but a scalar value. — The Alpha
– The Alpha, Commented Mar 13, 2014 at 21:21
Make sure the current invoice has a line_items, try using a different ID or try dd(Invoice::with('line_items')->get()) and check the result. — The Alpha
– The Alpha, Commented Mar 13, 2014 at 21:25
If I use the with keyword, it works. How come it does not without If I’ve set them up as per the Laravel docs? — Martin Bean
– Martin Bean, Commented Mar 13, 2014 at 21:29

mandril · Accepted Answer · 2014-05-06 02:41:46Z

7

change

public function line_items()

for

public function lineItems()

and it will work , tested in Laravel 4.1 :)

answered May 6, 2014 at 2:41

mandril

4013 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

brunocascio · Accepted Answer · 2014-03-13 22:14:46Z

0

Check your tables relations... (Schema)

Your FK must be lineitem_id... You have modified this? Laravel will configure automatically... Don't change this...

Then, try

$invoice->line_items() or $invoice->line_items in 4.1

answered Mar 13, 2014 at 22:14

brunocascio

2,0063 gold badges16 silver badges23 bronze badges

2 Comments

Martin Bean Over a year ago

I think you misunderstand. Invoices has many LineItems, therefore my line_items table has a foreign key called invoice_id that links it to its parent invoice row.

brunocascio Over a year ago

I See. Sorry. try change name, line_items instance of lineItems() Maybe collisions.. ?

WebNovice · Accepted Answer · 2014-03-14 05:10:07Z

0

Check for line_items before the foreach loop:

if(! $invoice->line_items->isEmpty()){
    foreach($invoice->line_items as $line_item){
        //do stuff
    }
}

Also, it won't hurt to explicitly mention the FK, although laravel will automatically try to do it for you provided you use proper names for your table fields.

//Invoice Model
return $this->hasMany('LineItem', 'invoice_id');

//LineItem Model
return $this->belongsTo('Invoice', 'invoice_id');

answered Mar 14, 2014 at 5:10

WebNovice

2,2203 gold badges25 silver badges42 bronze badges

Collectives™ on Stack Overflow

Issue with Laravel hasMany relation

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related