Gorilla Websocket - Read error: repeated read on failed websocket connection

Question

Using the gorilla websocket api for go, how do i know if a client is still connected?

What Im trying with now is:

func Listen(ws *websocket.Conn) {
    connTimeout := 3
    timeLastSent := time.Now().Second()

    for ((timeLastSent + connTimeout) % 60) != time.Now().Second() {

        msg := Message{}
        err := ws.ReadJSON(&msg)

        if err == websocket.ErrCloseSent {
            break
        } else if err != nil {
            continue
        }

        //Message recived
        EventMessage <- msg

        timeLastSent = time.Now().Second()
    }
  //Connection timed out.
    return
}

But this results in the error repeated read on failed websocket connection.

Ive been looking into using ws.SetReadDeadline(t), but Ive no idea of either how to use it nor if its even the thing Im looking for.

How should i go about this?

@JohnSmith I'm not sure how that would help :/ could you explain? — Olian04
– Olian04, Commented May 21, 2016 at 17:56
It shows how to handle ping/pong requests. Basically you don't really need to do anything other than handling the deadlines as it is in the example. Once there is no response from the client within the specified timeframe, you can just return (close the connection on the server). — John Smith
– John Smith, Commented May 21, 2016 at 18:03

user5728991 · Accepted Answer · 2021-06-26 17:01:26Z

5

When the websocket connection fails with an error other than websocket.ErrCloseSent, the program spins in a tight loop until the timeout.

To help applications detect this programming error, the websocket package panics when read is called 1000 times on a failed connection (view code here).

To fix the problem, break out of the loop on all errors:

    err := ws.ReadJSON(&msg)
    if err != nil {
        // optional: log the error
        break
    }

Collectives™ on Stack Overflow

Gorilla Websocket - Read error: repeated read on failed websocket connection

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related