Passing a PHP variable into a Javascript funtion

Question

I have a variable named $path. I want to pass this variable from PHP to a javascript function.

<button onclick='myFunctionContact(\"" . $row1['id'] . "\")'>
    <img border='0' alt='Contacts' src='".$imgpth."peoplesmall.png'>
</button>
<script>
function myFunctionContact(id) {
    window.open('!!!$path should go here!!!'+id, '', 'toolbar=no,scrollbars=yes,resizable=yes,top=200,left=500,width=400,height=400');
}
</script>

How do I get the URL in path to display inside of the function, in the desired place?

I tried printing the variable into a javascript variable and then placing that variable into the function, but the popup window no longer works when I do that.

function myFunctionContact(id) {
    var test1 = <?php echo $path; ?>;
    window.open(test1 +id, '', 'toolbar=no,scrollbars=yes,resizable=yes,top=200,left=500,width=400,height=400');
 }

I Know I am doing it wrong, but I have no idea how. Any advice would be greatly appreciated.

Possible duplicate of How to pass variables and data from PHP to JavaScript? — giorgio
– giorgio, Commented Nov 18, 2016 at 7:34
The path needs to be a quoted string. The end result of your echoed string has to, itself, contain quotes. — ppovoski
– ppovoski, Commented Nov 18, 2016 at 19:03

Ricardo Ortega Magaña · Accepted Answer · 2016-11-18 00:13:12Z

2

I think the problem is how you are echo the path:

Instead of:

var test1 = <?php echo $path; ?>

i think it should be

var test1 = <?php echo '"'.$path.'";'; ?>

answered Nov 18, 2016 at 0:13

Ricardo Ortega Magaña

2,44219 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Arthur Walker Over a year ago

Is there a reason it works fine with var myValue = <?php echo json_encode($path); ?>; ?

Ricardo Ortega Magaña Over a year ago

json_encode return a string with the " (double quotes) character, thats whats missing in your code.

Saleh Al Eit · Accepted Answer · 2016-11-17 23:37:15Z

0

You can always use a hidden input field, and set it's value to whatever you need to be used in your JS code, then grab that value of in your JS, or maybe try an ajax call to get the value you need.

answered Nov 17, 2016 at 23:37

Saleh Al Eit

1

1 Comment

giorgio Over a year ago

using a hidden input field is really bad practice. It works though.

Arthur Walker · Accepted Answer · 2016-11-18 01:08:34Z

0

json_encode() fixed the problem.

var myValue = <?php echo json_encode($path); ?>;

answered Nov 18, 2016 at 1:08

Arthur Walker

12511 bronze badges

1 Comment

giorgio Over a year ago

Json is not meant to encode values to be inputted into a javascript variable. json !== var

ppovoski · Accepted Answer · 2016-11-18 19:11:44Z

0

The path needs to be a quoted string. The end result of your echoed string has to, itself, contain quotes.

Assuming $path is a string, window.open is expecting a quoted string as the parameter.

function myFunctionContact(id) {
    window.open(' . $path . ' + id, '', 'toolbar=no,scrollbars=yes,resizable=yes,top=200,left=500,width=400,height=400');
}
</script>

answered Nov 18, 2016 at 19:11

ppovoski

4,8605 gold badges25 silver badges31 bronze badges

Collectives™ on Stack Overflow

Passing a PHP variable into a Javascript funtion

4 Answers 4

2 Comments

1 Comment

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related