Adding element with the splice method

Question

I am trying to Us the javascript splice method to add a "-" before every capital latter in my array but it is not working. I don't know what I am doing wrong. Here is my code below.

function spinalCase(str) {
  let strArr = [];
  for(let i = 0; i < str.length; i++){
    strArr.push(str[i]);
  }
  for(let i = 0; i < strArr.length; i++){
    if(strArr[i] !== strArr[i].toLowerCase()){
      strArr.splice(strArr.indexOf(strArr[i]),0, "-");
    }
  } 
console.log(strArr);
}

spinalCase('thisIsSpinalTap');

Andy · Accepted Answer · 2019-11-24 14:10:56Z

1

When you add a new element with splice you're increasing the length of the array and the loop is never able to finish. If you work the loop from the end of the array to the beginning instead you can avoid this problem.

function spinalCase(str) {
  let strArr = [];
  for (let i = 0; i < str.length; i++) {
    strArr.push(str[i]);
  }

  // Work the loop from the end to the beginning
  for (let i = strArr.length - 1; i >= 0 ; i--) {
    if (strArr[i] !== strArr[i].toLowerCase()) {
      strArr.splice(strArr.indexOf(strArr[i]), 0, "-");
    }
  }
  console.log(strArr.join(''));
}

spinalCase('thisIsSpinalTap');

answered Nov 24, 2019 at 14:10

Andy

63.6k13 gold badges72 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

marshy101 · Accepted Answer · 2019-11-24 14:30:28Z

1

I know you wanted to use splice, but here is a little regex solution; just in case.

function spinalCase(str) {
 return str.replace(/[A-Z]/g, "-$&").toLowerCase();
}

console.log(spinalCase("thisIsSpinalTap"))
// this-is-spinal-tap

answered Nov 24, 2019 at 14:30

marshy101

6048 silver badges19 bronze badges

Comments

sɐunıɔןɐqɐp · Accepted Answer · 2019-11-24 14:17:13Z

0

You changed your array when you do:

strArr.splice(strArr.indexOf(strArr[i]),0, "-");

So strArr.length is not constant for the loop for(let i = 0; i < strArr.length; i++)

edited Nov 24, 2019 at 14:17

sɐunıɔןɐqɐp

3,59516 gold badges41 silver badges43 bronze badges

answered Nov 24, 2019 at 14:08

Haiz

1344 bronze badges

Collectives™ on Stack Overflow

Adding element with the splice method

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related