can PHPStan detect that a @param can be an array of int, an array of string but not a mix of int and string?

Question

readonly class Identifier extends Regexp
{
    /**
     * @param array<int,int>|array<int,string> $possibleValues
     */
    public function __construct(array $possibleValues = [])
    {
        $regexp = implode('|', $possibleValues);
        parent::__construct('' !== $regexp ? $regexp : null);
    }
}

Everything works fine when i create an Identifierwith an array that contains a float, phpstan detects an error. But it does not detect any error when i create an Identifier with an array of int and string mixed like

$test = new Identifier([1,2,"test"];

Is there a way to tells phpStan that $possibleValues can be an array of int, an array of string but not a mix of int and string ?

Looking at the debug, it appears that it is collapsing the union down to array<int, int|string>. I tried with a List<int>|List<string> and some type aliases, but they all did the same thing, too. — Chris Haas
– Chris Haas, Commented Jun 26, 2024 at 13:12

Ondřej Mirtes · Accepted Answer · 2024-06-27 14:35:43Z

2

Yes, union of arrays is collapsed into an array of union. There's a feature request to change that: https://github.com/phpstan/phpstan/issues/8963

answered Jun 27, 2024 at 14:35

Ondřej Mirtes

5,85128 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ulrich Eckhardt Over a year ago

I just wanted to suggest filing a feature request and that the PHPStan maintainer is really quick to react, but you beat me to it. :)

Collectives™ on Stack Overflow

can PHPStan detect that a @param can be an array of int, an array of string but not a mix of int and string?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related