KeyPress and KeyDown events

Question

Hello I'm trying to make a program in WF that uses the KeyPress event. I've written the following code:

 private void Form1_KeyPress(object sender, KeyPressEventArgs e)
   {
     while (true)
     {
         switch (e.KeyChar)
         {
                    case (char)68:
                        MessageBox.Show("Test");
                        break;
         }
      }
}

But when I execute the program and press the key the message box doensn;t appear. Does anyone have any suggestions or knows how to fix this? I've also been told that a KeyDown event could work but I don't know how to work with those either.

Is this real code? It will hang your app independently of the actual key. — JeffRSon
– JeffRSon, Commented Apr 24, 2014 at 15:07

D Stanley · Accepted Answer · 2014-04-24 15:07:02Z

3

Don't use while(true) in an event handler. It will loop infinitely.

Just do

private void Form1_KeyPress(object sender, KeyPressEventArgs e)
{
    switch (e.KeyChar)
    {
        case (char)68:
            MessageBox.Show("Test");
            break;
    }
}

Also is seems cleaner to compare the pressed key to the actual character rather than the ASCII code:

    switch (e.KeyChar)
    {
        case 'D':
            MessageBox.Show("Test");
            break;
    }

answered Apr 24, 2014 at 15:07

D Stanley

153k12 gold badges189 silver badges257 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

huMpty duMpty · Accepted Answer · 2014-04-24 15:05:51Z

3

You need to set Form.KeyPreview

e.g. In your form

this.KeyPreview =true;

answered Apr 24, 2014 at 15:05

huMpty duMpty

14.5k14 gold badges64 silver badges102 bronze badges

Collectives™ on Stack Overflow

KeyPress and KeyDown events

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related